Async methods for NIORawSocketBootstrap
#2460
Conversation
| /// - Returns: A `NIOAsyncChannel` for the bound connection. | ||
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | ||
| @_spi(AsyncChannel) | ||
| public func bind<Inbound: Sendable, Outbound: Sendable>( |
There was a problem hiding this comment.
Should we be providing the initialiser for this (and connect) here?
We have a split world where you can specify it in the initialiser on the bootstrap and in some cases (protocol negotiation and the "return whatever you want from the initializer") in bind/connect.
It might be easier if all the async bind/connect methods have initialisers.
There was a problem hiding this comment.
Yeah realised this today as well but we gotta revisit it holistically. I will defer this to the overall API review.
There was a problem hiding this comment.
Did we not add them with inits in the other NIO bootstraps though?
There was a problem hiding this comment.
Nope, the NIOAsyncChannel based ones are all without an explicit initialiser
| /// - Returns: A `NIOAsyncChannel` for the bound connection. | ||
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | ||
| @_spi(AsyncChannel) | ||
| public func bind<Inbound: Sendable, Outbound: Sendable>( |
There was a problem hiding this comment.
Did we not add them with inits in the other NIO bootstraps though?
FranzBusch
force-pushed
the
fb-raw-socket-bootstrap
branch
from
b8786cc to
2a94c6e
Compare
FranzBusch
force-pushed
the
fb-raw-socket-bootstrap
branch
2 times, most recently
from
b63704c to
2bebb36
Compare
# Motivation We want to support async bootstrapping with all our bootstraps. # Modification This PR adds support for the `NIORawSocketBootstrap` and adds the three variants of methods to it (abstract output, `NIOAsyncChannel` based and protocol negotiation based) # Result We now support asynchronous interaction with the `NIORawSocketBootstrap`
FranzBusch
force-pushed
the
fb-raw-socket-bootstrap
branch
from
2bebb36 to
f8dbe9e
Compare
Motivation
We want to support async bootstrapping with all our bootstraps.
Modification
This PR adds support for the
NIORawSocketBootstrapand adds the three variants of methods to it (abstract output,NIOAsyncChannelbased and protocol negotiation based)Result
We now support asynchronous interaction with the
NIORawSocketBootstrap