Add async TCP echo example #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
4 times, most recently
from
438e2d1 to
e82a6c5
Compare
glbrntt
reviewed
Jul 12, 2023
weissi
reviewed
Jul 12, 2023
weissi
requested changes
Jul 13, 2023
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
from
6989109 to
a734501
Compare
|
@weissi I updated this PR to use your newly landed singletons. |
weissi
reviewed
Jul 27, 2023
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
from
a734501 to
a0766ec
Compare
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
from
a0766ec to
dad3348
Compare
weissi
reviewed
Jul 27, 2023
| ) { channel in | ||
| channel.eventLoop.makeCompletedFuture { | ||
| // We are using two simple handlers here to frame our messages with "\n" | ||
| try channel.pipeline.syncOperations.addHandler(ByteToMessageHandler(NewlineDelimiterCoder())) |
There was a problem hiding this comment.
all these trys should be try!s, they can't fail unless programmer error, right?
There was a problem hiding this comment.
They could throw if the channel is closed while we add the handler. I don't wanna show adopters a try! when it could fail in rare cases and I don't think the try is too bad.
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
from
dad3348 to
c20b082
Compare
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
from
0776379 to
1fa2d5e
Compare
glbrntt
reviewed
Jul 27, 2023
glbrntt
approved these changes
Jul 28, 2023
# Motivation We introduced new async APIs to our bootstraps that make it easy to use NIO from Swift Concurrency. We should provide examples showing how to use those new APIs. In the future, we want to make those examples the primary ones and remove the non-async based ones. # Modification This PR introduces two new targets: `NIOTCPEchoServer` and `NIOTCPEchoClient`. Both targets are executable and provide either the server or client piece of the example. # Result New and shiny async example
FranzBusch
force-pushed
the
fb-async-tcp-echo
branch
from
5034078 to
bea684c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We introduced new async APIs to our bootstraps that make it easy to use NIO from Swift Concurrency. We should provide examples showing how to use those new APIs. In the future, we want to make those examples the primary ones and remove the non-async based ones.
Modification
This PR introduces two new targets:
NIOTCPEchoServerandNIOTCPEchoClient. Both targets are executable and provide either the server or client piece of the example.Result
New and shiny async example