Call NIOAsyncWriterSinkDelegate outside of the lock
#2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Oct 11, 2023
| delegate: delegate | ||
| ) | ||
|
|
||
| return .callDidYield(delegate) |
There was a problem hiding this comment.
What happens to sequence in this branch? It looks like we just ignore it
There was a problem hiding this comment.
I see where the confusion is coming from. We are just yielding it to the delegate right away when we return callDidYield. The caller of this method still has the sequence.
There was a problem hiding this comment.
Ah, gotcha, thanks for clarifying.
# Motivation The current `NIOAsyncWriter` implementation expects that the delegate is called while holding the lock to avoid reentrancy issues. However, this prevents us from executing the delegate calls directly on the `EventLoop` if we are on it already. # Modification This moves all of the delegate calls outside of the locks and adds protection against reentrancy into the state machine. # Result Less allocations. Clarify the reentrancy problems in docs and protect against them in the writer
FranzBusch
force-pushed
the
fb-async-writer-performance
branch
from
cde1274 to
378e01f
Compare
glbrntt
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
NIOAsyncWriterimplementation expects that the delegate is called while holding the lock to avoid reentrancy issues. However, this prevents us from executing the delegate calls directly on theEventLoopif we are on it already.Modification
This moves all of the delegate calls outside of the locks and adds protection against reentrancy into the state machine.
Result
Less allocations.