Throw error when the max read amount is greater than ByteBuffer
can tolerate
#2911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As described in issue #2878, NIOFileSystem crashes when reading more than
ByteBuffer
capacity.Modifications:
byteBufferCapacity
, toByteCount
representing the maximum amount of bytes that can be written toByteBuffer
.FileSystemError
inReadableFileHandleProtocol.readToEnd(fromAbsoluteOffset:maximumSizeAllowed:)
whenmaximumSizeAllowed
is more thanByteCount.byteBufferCapacity
.Result:
NIOFileSystem will
throw
instead of crashing.