Add future wait benchmark to catch memory leaks #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In the past we introduced a memory leak around the creation of and waiting on futures - we should protect against leaks in this fundamental operation. Modifications: Add a new benchmark which would have failed with the previous bug Result: Regression protection for this type of memory leak.
Lukasa
approved these changes
Oct 17, 2024
FranzBusch
reviewed
Oct 17, 2024
Comment on lines
+24
to
+27
| let leakMetrics: [BenchmarkMetric] = [ | ||
| .mallocCountTotal, | ||
| .memoryLeaked, | ||
| ] |
There was a problem hiding this comment.
I wanted to add one comment here. Should we add leaks to all of our benchmarks. Seems like we had that before in the old school alloc tests.
There was a problem hiding this comment.
Maybe. Unfortunately it seems like there isn't a simple "detect leaks" lever to pull here. Even in a case where I manufactured a leak I had to tweak the configuration carefully to have it detected. We could copy that configuration and hope it would detect any leak but doing so would slow down the benchmarks significantly. I'm planning on investigating jemalloc in more detail to see if we can do anything to make leak detection more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In the past we introduced a memory leak around the creation of and waiting on futures - we should protect against leaks in this fundamental operation.
Modifications:
Add a new benchmark which would have failed with the previous bug
Result:
Regression protection for this type of memory leak.