[CI] Fix the Windows 6.0 check name #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-gha-windows-naming
branch
6 times, most recently
from
4874873
to
4aae502
Compare
# Motivation Currently, the Windows 6.0 check name includes the matrix properties. # Modification This PR makes it dynamic with the swift version again. # Result Aligned CI check names across platforms.
FranzBusch
force-pushed
the
fb-gha-windows-naming
branch
from
4aae502
to
43eb1ff
Compare
FranzBusch
commented
Oct 23, 2024
| @@ -159,7 +159,6 @@ jobs: | |||
| - image: swift:6.0-windowsservercore-ltsc2022 | |||
| swift_version: "6.0" | |||
| enabled: ${{ inputs.matrix_windows_6_0_enabled }} | |||
| if: ${{ inputs.matrix_windows_6_0_enabled }} | |||
There was a problem hiding this comment.
These if checks caused the naming problems since those are evaluated before the matrix so if we disabled the check then the names would get bad
PeterAdams-A
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the Windows 6.0 check name includes the matrix properties.
Modification
This PR makes it dynamic with the swift version again.
Result
Aligned CI check names across platforms.