BaseSocketChannel flushNow IONotificationState changes #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We could previously hit an assert do to a re-entrancy issue where channel and buffered write state could change during a call-out leading to invalid state. Modifications: The decision on whether or not we should be registered for future writes is now taken after the call outs to `fireChannelWritabilityChanged` and `fireChannelReadComplete`. The new registration state is set to `.unregister` if the channel is not open or if there are now flushed pending writes. Result: Scope for re-entrancy crashes is reduced. Co-authored-by: Cory Benfield <lukasa@apple.com>
rnro
force-pushed
the
base_socket_crash
branch
from
7bb69ad to
c895291
Compare
Lukasa
approved these changes
Oct 30, 2024
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 21, 2024
### Motivation: We could previously hit an assert do to a re-entrancy issue where channel and buffered write state could change during a call-out leading to invalid state. ### Modifications: The decision on whether or not we should be registered for future writes is now taken after the call outs to `fireChannelWritabilityChanged` and `fireChannelReadComplete`. The new registration state is set to `.unregister` if the channel is not open or if there are now flushed pending writes. ### Result: Scope for re-entrancy crashes is reduced. Co-authored-by: Cory Benfield <lukasa@apple.com> (cherry picked from commit fdc3a31)
Lukasa
added a commit
that referenced
this pull request
Nov 21, 2024
…) (#2981) ### Motivation: We could previously hit an assert do to a re-entrancy issue where channel and buffered write state could change during a call-out leading to invalid state. ### Modifications: The decision on whether or not we should be registered for future writes is now taken after the call outs to `fireChannelWritabilityChanged` and `fireChannelReadComplete`. The new registration state is set to `.unregister` if the channel is not open or if there are now flushed pending writes. ### Result: Scope for re-entrancy crashes is reduced. Co-authored-by: Cory Benfield <lukasa@apple.com> (cherry picked from commit fdc3a31) Co-authored-by: Rick Newton-Rogers <rnro@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We could previously hit an assert do to a re-entrancy issue where channel and buffered write state could change during a call-out leading to invalid state.
Modifications:
The decision on whether or not we should be registered for future writes is now taken after the call outs to
fireChannelWritabilityChangedandfireChannelReadComplete. The new registration state is set to.unregisterif the channel is not open or if there are now flushed pending writes.Result:
Scope for re-entrancy crashes is reduced.