Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking technique #2963

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fix leaking technique #2963

merged 1 commit into from
Nov 3, 2024

Conversation

asdf-bro
Copy link
Contributor

@asdf-bro asdf-bro commented Nov 2, 2024

Using Unmanaged.passRetained is correct and therefore safe under all compiler optimizations

@asdf-bro
Fix leaking technique
89802ba 
Using Unmanaged.passRetained is correct and therefore safe under all compiler optimizations
Lukasa
Lukasa approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lukasa Lukasa enabled auto-merge (squash) November 3, 2024 19:33
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Nov 3, 2024
@Lukasa Lukasa merged commit 3fda943 into apple:main Nov 3, 2024
41 of 44 checks passed
Lukasa pushed a commit to Lukasa/swift-nio that referenced this pull request Nov 21, 2024
@asdf-bro @Lukasa
Fix leaking technique (apple#2963)
859fcbe 
Using `Unmanaged.passRetained` is correct and therefore safe under all
compiler optimizations

(cherry picked from commit 3fda943)
Lukasa added a commit that referenced this pull request Nov 21, 2024
@Lukasa @asdf-bro
Fix leaking technique (#2963) (#2989)
04ef7b4 
Using `Unmanaged.passRetained` is correct and therefore safe under all
compiler optimizations

(cherry picked from commit 3fda943)

Co-authored-by: Philip Brown <122590765+asdf-bro@users.noreply.github.com>
@0xTim 0xTim mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdf-bro @Lukasa