Improve coverage of isolated views #3069
Merged
+241
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We were only testing the isolated views on SelectablEventLoop. That was fine when all the implementation was common, but it isn't going to be anymore, so we should start having tests across all our EL kinds. Modifications: Refactor the tests to take their EL as an argument Add support for ELs that need to be explicitly run Add tests for NIOAsyncTestingEL and EmbeddedEL Result: Better test coverage.
FranzBusch
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We were only testing the isolated views on SelectableEventLoop. That was fine when all the implementation was common, but it isn't going to be anymore, so we should start having tests across all our EL kinds.
Modifications:
Refactor the tests to take their EL as an argument
Add support for ELs that need to be explicitly run
Add tests for NIOAsyncTestingEL and EmbeddedEL
Result:
Better test coverage.