Strict concurrency for SelectableEventLoop & MTELG #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation SelectableEventLoop and MTEL are our major entry points for execution. These need to be strict concurrency clean. Unfortunately, changes in one tend to ripple into the other, so we need to tackle both at once. Ideally we would not use `@unchecked Sendable` for SelectableEventLoop. With NIOLoopBound and our other tools, I think we have a real shot at getting the compiler to prove much more of the correctness of this type. However, right now that's not prudent: we'd like to unblock the rest of the ecosystem. So we'll tolerate an `@unchecked Sendable` for now, with a plan to revisit. Modifications - SelectableEventLoop is @unchecked Sendable - A few closures get annotated @sendable - Add a NIOLockedValueBox to convince the compiler that this use is safe. - Make a few types explicitly not Sendable Result No concurrency warnings in MTELG and SelectableEventLoop.
gjcairo
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SelectableEventLoop and MTEL are our major entry points for execution. These need to be strict concurrency clean. Unfortunately, changes in one tend to ripple into the other, so we need to tackle both at once.
Modifications
Result
No concurrency warnings in MTELG and SelectableEventLoop.