propagate exit code in integration tests in verbose mode #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Previously the integration tests ran in verbose mode wouldn't actually fail as we didn't correctly propagate the exit code. Modifications: correctly propagate the exit code Result: integration tests correctly fail in verbose mode too
weissi
force-pushed
the
jw-itestsv-errcode
branch
from
17eed7a
to
d1fcfa0
Compare
normanmaurer
approved these changes
Apr 12, 2018
Lukasa
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously the integration tests ran in verbose mode wouldn't actually
fail as we didn't correctly propagate the exit code.
Modifications:
correctly propagate the exit code
Result:
integration tests correctly fail in verbose mode too