-
Notifications
You must be signed in to change notification settings - Fork 679
Add unix domain socket based async channel test #3225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danieleggert
wants to merge
6
commits into
apple:main
Choose a base branch
from
danieleggert:add-unix-domain-socket-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+167
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
02b2d6d
Add unix domain socket based async channel test
danieleggert 05699f2
Guard Swift Testing code with #if + #endif
danieleggert 6771f4e
Whitespace
danieleggert 50b00c9
Merge branch 'main' into add-unix-domain-socket-test
danieleggert 3263be8
Bump / update @available versions
danieleggert ffcfbcb
Propagate error from handleConnection()
danieleggert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
167 changes: 167 additions & 0 deletions
167
Tests/NIOCoreTests/AsyncChannel/AsynChannelUnixDomainSocketTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,167 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the SwiftNIO open source project | ||
// | ||
// Copyright (c) 2025 Apple Inc. and the SwiftNIO project authors | ||
// Licensed under Apache License v2.0 | ||
// | ||
// See LICENSE.txt for license information | ||
// See CONTRIBUTORS.txt for the list of SwiftNIO project authors | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
//===----------------------------------------------------------------------===// | ||
#if canImport(Testing) | ||
import NIOPosix | ||
import Testing | ||
|
||
@testable import NIOCore | ||
|
||
@Suite | ||
private enum AsynChannelUnixDomainSocketTests { | ||
/// This is a end-to-end async channel based test. | ||
/// | ||
/// The server side listens on a UNIX domain socket, and the client connects to this socket. | ||
/// | ||
/// The server and client exchange simple, line based messages. | ||
@available(macOS 14.0, iOS 17, tvOS 17, watchOS 10, *) | ||
@Test() | ||
static func runServer() async throws { | ||
try await confirmation("Client did receive message") { clientDidReceive in | ||
try await confirmation("Server did receive message") { serverDidReceive in | ||
try await check( | ||
clientDidReceive: clientDidReceive, | ||
serverDidReceive: serverDidReceive | ||
) | ||
} | ||
} | ||
} | ||
} | ||
|
||
@available(macOS 14.0, iOS 17, tvOS 17, watchOS 10, *) | ||
private func check( | ||
clientDidReceive: Confirmation, | ||
serverDidReceive: Confirmation | ||
) async throws { | ||
// This uses a hard-coded path. | ||
// | ||
// The path of a UNIX domain socket has a relatively low limit on its total | ||
// length, and we thus can not put this inside some (potentially) deeply | ||
// nested directory hierarchy. | ||
let path = "/tmp/9ac7750dc22a066066871aadf481e31a" | ||
let serverChannel = try await makeServerChannel(path: path) | ||
|
||
try await withThrowingDiscardingTaskGroup { group in | ||
try await serverChannel.executeThenClose { inbound in | ||
group.addTask { | ||
// Create a client connection to the server: | ||
let clientChannel = try await makeClientChannel(path: path) | ||
print("Executing client channel") | ||
try await clientChannel.executeThenClose { inbound, outbound in | ||
print("C: Sending hello") | ||
try await outbound.write("Hello") | ||
|
||
var inboundIterator = inbound.makeAsyncIterator() | ||
guard let messageA = try await inboundIterator.next() else { return } | ||
print("C: Did receive '\(messageA)'") | ||
clientDidReceive.confirm() | ||
#expect(messageA == "Hello") | ||
|
||
try await outbound.write("QUIT") | ||
} | ||
} | ||
|
||
for try await connectionChannel in inbound { | ||
group.addTask { | ||
print("Handling new connection") | ||
try await handleConnection( | ||
channel: connectionChannel, | ||
serverDidReceive: serverDidReceive | ||
) | ||
print("Done handling connection") | ||
} | ||
break | ||
} | ||
} | ||
} | ||
} | ||
|
||
private func makeServerChannel( | ||
path: String | ||
) async throws -> NIOAsyncChannel<NIOAsyncChannel<String, String>, Never> { | ||
try await ServerBootstrap( | ||
group: NIOSingletons.posixEventLoopGroup | ||
).bind( | ||
unixDomainSocketPath: path, | ||
cleanupExistingSocketFile: true, | ||
serverBackPressureStrategy: nil | ||
) { childChannel in | ||
childChannel.eventLoop.makeCompletedFuture { | ||
try childChannel.pipeline.syncOperations.addHandler(ByteToMessageHandler(NewlineDelimiterCoder())) | ||
try childChannel.pipeline.syncOperations.addHandler(MessageToByteHandler(NewlineDelimiterCoder())) | ||
return try NIOAsyncChannel<String, String>( | ||
wrappingChannelSynchronously: childChannel | ||
) | ||
} | ||
} | ||
} | ||
|
||
private func makeClientChannel( | ||
path: String | ||
) async throws -> NIOAsyncChannel<String, String> { | ||
try await ClientBootstrap(group: NIOSingletons.posixEventLoopGroup) | ||
.connect(unixDomainSocketPath: path) | ||
.flatMap { channel in | ||
channel.eventLoop.makeCompletedFuture { | ||
try channel.pipeline.syncOperations.addHandler(ByteToMessageHandler(NewlineDelimiterCoder())) | ||
try channel.pipeline.syncOperations.addHandler(MessageToByteHandler(NewlineDelimiterCoder())) | ||
return try NIOAsyncChannel<String, String>(wrappingChannelSynchronously: channel) | ||
} | ||
} | ||
.get() | ||
} | ||
|
||
private func handleConnection( | ||
channel: NIOAsyncChannel<String, String>, | ||
serverDidReceive: Confirmation | ||
) async throws { | ||
print("S: New channel") | ||
try await channel.executeThenClose { inbound, outbound in | ||
for try await message in inbound { | ||
print("S: Did receive '\(message)'") | ||
guard message != "QUIT" else { return } | ||
serverDidReceive.confirm() | ||
try await outbound.write(message) | ||
} | ||
print("S: Bye") | ||
} | ||
} | ||
|
||
/// A simple newline based encoder and decoder. | ||
private final class NewlineDelimiterCoder: ByteToMessageDecoder, MessageToByteEncoder { | ||
typealias InboundIn = ByteBuffer | ||
typealias InboundOut = String | ||
|
||
private let newLine = UInt8(ascii: "\n") | ||
|
||
init() {} | ||
|
||
func decode(context: ChannelHandlerContext, buffer: inout ByteBuffer) throws -> DecodingState { | ||
let readableBytes = buffer.readableBytesView | ||
|
||
if let firstLine = readableBytes.firstIndex(of: self.newLine).map({ readableBytes[..<$0] }) { | ||
buffer.moveReaderIndex(forwardBy: firstLine.count + 1) | ||
// Fire a read without a newline | ||
context.fireChannelRead(Self.wrapInboundOut(String(buffer: ByteBuffer(firstLine)))) | ||
return .continue | ||
} else { | ||
return .needMoreData | ||
} | ||
} | ||
|
||
func encode(data: String, out: inout ByteBuffer) throws { | ||
out.writeString(data) | ||
out.writeInteger(self.newLine) | ||
} | ||
} | ||
#endif // canImport(Testing) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the prints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even in test code? This is super helpful for diagnosing these when they fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have ST-0009 with Swift 6.2, this could/should probably use
Attachment.record()
.