Drop Swift 5.10 #3393
Drop Swift 5.10 #3393
Conversation
Package.swift
Outdated
| // compatibility with previous NIO versions. | ||
| let historicalNIOPosixDependencyRequired: [Platform] = [.macOS, .iOS, .tvOS, .watchOS, .linux, .android] | ||
|
|
||
| let strictConcurrencyDevelopment = false |
|
API breakage false positive: This is a |
.github/workflows/benchmarks.yml
Outdated
| type: boolean | ||
| description: "Boolean to enable the Linux 5.10 Swift version matrix job. Defaults to true." | ||
| default: true | ||
| default: false |
There was a problem hiding this comment.
I don't think we can do this yet - there are significant numbers of repositories which don't yet have 6.2 CI and require 5.10
There was a problem hiding this comment.
oh I see. I thought this is only for this workflow. will change
This reverts commit fc715c7.
.github/workflows/main.yml
Outdated
| # Workaround https://github.com/nektos/act/issues/1875 | ||
| uses: apple/swift-nio/.github/workflows/unit_tests.yml@main | ||
| with: | ||
| linux_5_10_enabled: false |
There was a problem hiding this comment.
I don't love adding lines like this because we just need to go and clean them up later, I'd prefer to just wait until the default switches to off - but I don't think it blocks the PR, I'm willing to see how much of a pain it is in practice to clean up
This reverts commit bf83c6a.
| // Note: Whitespace changes are used to workaround compiler bug | ||
| // Remove when compiler version 5.10 is no longer supported. | ||
| // https://github.com/swiftlang/swift/issues/79285 | ||
| // swift-format-ignore |
There was a problem hiding this comment.
We can and should remove this.
Sources/NIOCore/NIOLoopBound.swift
Outdated
| #if compiler(>=6.0) | ||
| // Note: Whitespace changes are used to workaround compiler bug | ||
| // Remove when compiler version 5.10 is no longer supported. | ||
| // https://github.com/swiftlang/swift/issues/79285 |
There was a problem hiding this comment.
We can and should remove the whitespace changes.
|
Merging over the expected API break. |
This PR drops Swift 5.10 and enables Swift 6 language mode.