Add WebSocketUpgrader to channel config #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The NIOWebSocketServer demo works much better, when it actually configures the WebSocketUpgrader. You should have a test for that! Modifications: This adds the `upgrader` to the `HTTPUpgradeConfiguration`. Result: The demo will actually perform something web-sockety.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Lukasa
approved these changes
Apr 19, 2018
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The NIOWebSocketServer demo works wayyy better, when it actually configures the WebSocketUpgrader.
Modifications:
This adds the
upgraderto theHTTPUpgradeConfiguration.Result:
The demo will actually perform something web-sockety.
P.S.
You should have a test for that!