Generate matrix nested manifests #3431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The genereate matrix script attempts to derive the minimum Swift version supported by the package so that it doesn't run CI on versions which are older than that supported. At the moment it can't cope with repositories with packages in subdirectories like swift-nio-examples. Modifications: The script looks for manifests in subdirectories. Result: CI should generate more appropriate jobs.
rnro
force-pushed
the
generate_matrix_nested_manifests
branch
from
cb72936 to
08a67fb
Compare
This reverts commit 08a67fb.
Lukasa
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate matrix script finds manifests in subdirs
Motivation:
The genereate matrix script attempts to derive the minimum Swift version
supported by the package so that it doesn't run CI on versions which are
older than that supported. At the moment it can't cope with repositories
with packages in subdirectories like swift-nio-examples.
Modifications:
The script looks for manifests in subdirectories if
FIND_SUBDIRECTORY_MANIFESTS_ENABLED=true. This is opt-in because by default CI only uses the top-level manifests.Result:
CI should generate more appropriate jobs.
An example of this in action https://github.com/apple/swift-nio/actions/runs/18968739126/job/54171197381?pr=3431