canonical form for headers: fast path for 0 headers #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's quite common that someone asks for the canonical form of a header and we don't have any header values. There's no need to do string comparisons then, we can just return an empty array. Modifications: Check if we're asking for a header that isn't present and if so, just return the empty array. Result: Should be ever so slightly faster.
weissi
force-pushed
the
jw-fastpath-for-1-header
branch
from
17ae4c7
to
5d92b67
Compare
Lukasa
approved these changes
Apr 22, 2018
normanmaurer
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's quite common that someone asks for the canonical form of a header
and we don't have any header values. There's no need to do string
comparisons then, we can just return an empty array.
Modifications:
Check if we're asking for a header that isn't present and if so, just
return the empty array.
Result:
Should be ever so slightly faster.