Not cause a CoW when calling ByteBuffer.discardReadBytes() while it wa… #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
discard_read_bytes_consumed
branch
from
5d614a1
to
6552b6a
Compare
normanmaurer
changed the title
Lukasa
requested changes
Apr 26, 2018
Sources/NIO/ByteBuffer-core.swift
Outdated
| @@ -550,6 +550,13 @@ public struct ByteBuffer { | |||
| return false | |||
| } | |||
|
|
|||
| if self._readerIndex == self.writerIndex { | |||
There was a problem hiding this comment.
Why are we hitting different indices here, one underscored and one not?
There was a problem hiding this comment.
because I have fat fingers 🤤 ... Let me fix it.
…as fully consumed. Motivation: We should not need to trigger any copy when the ByteBuffer was fully consumed and discardReadBytes() is called. Modifications: - If fully consumed just reset reader and writer Index. - Add unit test Result: Less memory copies
normanmaurer
force-pushed
the
discard_read_bytes_consumed
branch
from
ced18e7
to
c2da566
Compare
Lukasa
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s fully consumed.
Motivation:
We should not need to trigger any copy when the ByteBuffer was fully consumed and discardReadBytes() is called.
Modifications:
Result:
Less memory copies