make BB.debugDescription print xxd -r -p compatible format #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weissi can you please rebase and resolve the conflicts ? |
normanmaurer
approved these changes
Apr 27, 2018
Motivation:
When debugging, I often use ByteBuffer.debugDescription which dumps
the bytes. Unfortunately, the format wasn't compatible with what
`xxd -r -p` expects. Now you can just copy some output, for example
echo '04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 10 11 12' | xxd -r -p
and xxd -r -p will correctly parse the byte values.
Modifications:
made BB.debugDescription prefix byte values under 0x10 with a 0 instead
of a space.
Result:
easier debugging with the standard tools
|
@normanmaurer done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When debugging, I often use ByteBuffer.debugDescription which dumps
the bytes. Unfortunately, the format wasn't compatible with what
xxd -r -pexpects. Now you can just copy some output, for exampleand xxd -r -p will correctly parse the byte values.
Modifications:
made BB.debugDescription prefix byte values under 0x10 with a 0 instead
of a space.
Result:
easier debugging with the standard tools