remove assertion that String.UTF8View doesn't underestimate count #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: I left an assertion that String.UTF8View's underestimatedCount is equal to the actual count of UTF-8 code units. It's good to see that it never failed so far so we can expect it to be really good which is important for performance. However, there's no problem if it does actually underestimate maybe for some special kind of Strings. So the assertion really isn't meaningful. Modifications: Remove the assertion. Result: Most likely nothing but we will not crash on something that we shouldn't crash on.
normanmaurer
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I left an assertion that String.UTF8View's underestimatedCount is equal
to the actual count of UTF-8 code units. It's good to see that it never
failed so far so we can expect it to be really good which is important
for performance.
However, there's no problem if it does actually underestimate maybe for
some special kind of Strings. So the assertion really isn't meaningful.
Modifications:
Remove the assertion.
Result:
Most likely nothing but we will not crash on something that we
shouldn't crash on.