Add a pull request template #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adjusted the notice accordingly.
Member
|
@swift-server-bot test this please |
simonjbeaumont
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To help maintain consistency in pull request descriptions, and encourage PR authors to provide enough information to reviewers upfront, let's add a PR template to the repo.
Modifications
Added a PR template file based on the SwiftNIO one, with slight modifications (removed colons in headings, added a test plan section). Adjusted the NOTICE file to reflect that.
Result
PR authors will be presented with the template when creating a new PR using GitHub's UI or tools that support templates.
Test Plan
Well, this PR is already being open using the template :)