Provide environment variable configuration option #1279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are currently providing a config option to provide a path to the
protoc
binary. This works great if yourprotoc
is always the same; however, for a lot of packages you want to build them on various systems and the path toprotoc
is always different. We really can't solve this with any config file.Modification
This PR adds the option to set the
PROTOC_PATH
env variable and picks it up in the plugin to find the protoc binary.Result
We can now dynamically pass the protoc path to the plugin.