Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x branch: Bump the Swift 5.7.0 testing to 5.7.2. #1354

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

thomasvl
Copy link
Collaborator

@thomasvl thomasvl commented Jan 6, 2023

No description provided.

@thomasvl thomasvl changed the title Bump the Swift 5.7.0 testing to 5.7.2. 1.x branch: Bump the Swift 5.7.0 testing to 5.7.2. Jan 6, 2023
@thomasvl
Copy link
Collaborator Author

thomasvl commented Jan 6, 2023

The 4.2.4 failure is because of the protobuf compiler requirements, so unrelated.

@thomasvl thomasvl merged commit b881abc into apple:1_x_release_branch Jan 6, 2023
@thomasvl thomasvl deleted the 1_x_swift_version branch January 6, 2023 17:58
@tbkka
Copy link
Contributor

tbkka commented Jan 6, 2023

This doesn't make any sense at all. Protobuf build is claiming:

-- The C compiler identification is GNU 5.4.0

but the Ubuntu 22.04 image we're using should be this one: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20221212.1
which only lists GCC 9, 10, 11, and 12 as supported compilers according to sbom.json.

GCC 5.4.0 was released in 2016; I can't believe that's really the compiler in this image.

@tbkka
Copy link
Contributor

tbkka commented Jan 6, 2023

Hmmm... In the 4.2.4 test run, "Update and Checkout dependencies" shows

g++ is already the newest version (4:5.3.1-1ubuntu1).
g++ set to manually installed.

@thomasvl
Copy link
Collaborator Author

thomasvl commented Jan 6, 2023

22.04 shouldn't be coming into play, the swift image is the controlling factor: https://github.com/apple/swift-protobuf/blob/1_x_release_branch/.github/workflows/build.yml#L70

@tbkka
Copy link
Contributor

tbkka commented Jan 6, 2023

Ah. Then I think I'm inclined to drop the 4.2.4 CI job entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants