Validate length before turning into an Int. #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Delimited isn't covered in fuzz testing, and generally decoding options aren't covered in fuzz testing. I think I've got an idea how to add the options without breaking the existing cases, I'll try to find time for that at some point. |
allevato
approved these changes
Feb 14, 2023
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Feb 14, 2023
1.x branch version of apple#1375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much an edge case, but something I noticed while working on some objc things.