Block more things #1469
Merged
Block more things #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm sorta surprised the generated_names have worked up until now; but play is safe and ensure we never generate a struct (message) or enum (enum or oneof) with some of the common things used in conformances or for scoping symbols, as when it goes wrong, things are very confusing.
tbkka
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if one tries to move say
Sendableoff the generatedextension [MessageName]and declare it when thestructis declare, then things go comically wrong as the compiler decides we're trying to say all the otherstructs try to use the local version of Sendable which is anotherstruct. And trying to scope it asSwift.Sendablealso fails, because the locally definedSwiftgets in the way.I guess no one has ever really hit this in the field, but it seems better to play it safe and force any attempt to use these as type should get them remapped to avoid the potential confusion they will create.