Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Visitor traversal logic to use statically defined Field descriptors #1504

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Visitor traversal logic to use statically defined Field descriptors #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ae1496
Implement Field and update traverse implementation to use static _fi…
mrabiciu Nov 22, 2023
23cadb6
run make regenerate
mrabiciu Nov 22, 2023
0ee2fba
Implicit isUnset for message fields, and move _fields to _MessageImpl…
mrabiciu Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,253 changes: 343 additions & 910 deletions FuzzTesting/Sources/FuzzCommon/fuzz_testing.pb.swift
View file
Open in desktop

Large diffs are not rendered by default.

1,418 changes: 738 additions & 680 deletions Protos/SwiftProtobufTests/generated_swift_names_enum_cases.proto
View file
Open in desktop

Large diffs are not rendered by default.

58 changes: 58 additions & 0 deletions Protos/SwiftProtobufTests/generated_swift_names_enums.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ message GeneratedSwiftReservedEnums {
enum EnumValueOptions { NONE_EnumValueOptions = 0; }
enum Equatable { NONE_Equatable = 0; }
enum Error { NONE_Error = 0; }
enum escaping { NONE_escaping = 0; }
enum ExpressibleByArrayLiteral { NONE_ExpressibleByArrayLiteral = 0; }
enum ExpressibleByDictionaryLiteral { NONE_ExpressibleByDictionaryLiteral = 0; }
enum ext { NONE_ext = 0; }
Expand All @@ -292,6 +293,8 @@ message GeneratedSwiftReservedEnums {
enum extension { NONE_extension = 0; }
enum ExtensionField { NONE_ExtensionField = 0; }
enum extensionFieldNumber { NONE_extensionFieldNumber = 0; }
enum extensionFields { NONE_extensionFields = 0; }
enum extensionFieldsAsMessageSet { NONE_extensionFieldsAsMessageSet = 0; }
enum ExtensionFieldValueSet { NONE_ExtensionFieldValueSet = 0; }
enum ExtensionMap { NONE_ExtensionMap = 0; }
enum extensionRange { NONE_extensionRange = 0; }
Expand Down Expand Up @@ -349,6 +352,7 @@ message GeneratedSwiftReservedEnums {
enum GeneratedCodeInfo { NONE_GeneratedCodeInfo = 0; }
enum get { NONE_get = 0; }
enum getExtensionValue { NONE_getExtensionValue = 0; }
enum getValue { NONE_getValue = 0; }
enum googleapis { NONE_googleapis = 0; }
enum Google_Protobuf_Any { NONE_Google_Protobuf_Any = 0; }
enum Google_Protobuf_Api { NONE_Google_Protobuf_Api = 0; }
Expand Down Expand Up @@ -526,6 +530,7 @@ message GeneratedSwiftReservedEnums {
enum isExtension { NONE_isExtension = 0; }
enum isInitialized { NONE_isInitialized = 0; }
enum isNegative { NONE_isNegative = 0; }
enum isUnset { NONE_isUnset = 0; }
enum itemTagsEncodedSize { NONE_itemTagsEncodedSize = 0; }
enum iterator { NONE_iterator = 0; }
enum javaGenerateEqualsAndHash { NONE_javaGenerateEqualsAndHash = 0; }
Expand Down Expand Up @@ -580,6 +585,7 @@ message GeneratedSwiftReservedEnums {
enum major { NONE_major = 0; }
enum makeAsyncIterator { NONE_makeAsyncIterator = 0; }
enum makeIterator { NONE_makeIterator = 0; }
enum map { NONE_map = 0; }
enum mapEntry { NONE_mapEntry = 0; }
enum MapKeyType { NONE_MapKeyType = 0; }
enum mapToMessages { NONE_mapToMessages = 0; }
Expand Down Expand Up @@ -636,6 +642,7 @@ message GeneratedSwiftReservedEnums {
enum numberValue { NONE_numberValue = 0; }
enum objcClassPrefix { NONE_objcClassPrefix = 0; }
enum of { NONE_of = 0; }
enum oneOf { NONE_oneOf = 0; }
enum oneofDecl { NONE_oneofDecl = 0; }
enum OneofDescriptorProto { NONE_OneofDescriptorProto = 0; }
enum oneofIndex { NONE_oneofIndex = 0; }
Expand All @@ -659,8 +666,22 @@ message GeneratedSwiftReservedEnums {
enum p { NONE_p = 0; }
enum package { NONE_package = 0; }
enum packed { NONE_packed = 0; }
enum packedBool { NONE_packedBool = 0; }
enum packedDouble { NONE_packedDouble = 0; }
enum packedEnum { NONE_packedEnum = 0; }
enum PackedEnumExtensionField { NONE_PackedEnumExtensionField = 0; }
enum PackedExtensionField { NONE_PackedExtensionField = 0; }
enum packedFixed32 { NONE_packedFixed32 = 0; }
enum packedFixed64 { NONE_packedFixed64 = 0; }
enum packedFloat { NONE_packedFloat = 0; }
enum packedInt32 { NONE_packedInt32 = 0; }
enum packedInt64 { NONE_packedInt64 = 0; }
enum packedSFixed32 { NONE_packedSFixed32 = 0; }
enum packedSFixed64 { NONE_packedSFixed64 = 0; }
enum packedSInt32 { NONE_packedSInt32 = 0; }
enum packedSInt64 { NONE_packedSInt64 = 0; }
enum packedUInt32 { NONE_packedUInt32 = 0; }
enum packedUInt64 { NONE_packedUInt64 = 0; }
enum padding { NONE_padding = 0; }
enum parent { NONE_parent = 0; }
enum parse { NONE_parse = 0; }
Expand Down Expand Up @@ -737,11 +758,29 @@ message GeneratedSwiftReservedEnums {
enum readBytes { NONE_readBytes = 0; }
enum register { NONE_register = 0; }
enum repeated { NONE_repeated = 0; }
enum repeatedBool { NONE_repeatedBool = 0; }
enum repeatedBytes { NONE_repeatedBytes = 0; }
enum repeatedDouble { NONE_repeatedDouble = 0; }
enum repeatedEnum { NONE_repeatedEnum = 0; }
enum RepeatedEnumExtensionField { NONE_RepeatedEnumExtensionField = 0; }
enum RepeatedExtensionField { NONE_RepeatedExtensionField = 0; }
enum repeatedFieldEncoding { NONE_repeatedFieldEncoding = 0; }
enum repeatedFixed32 { NONE_repeatedFixed32 = 0; }
enum repeatedFixed64 { NONE_repeatedFixed64 = 0; }
enum repeatedFloat { NONE_repeatedFloat = 0; }
enum repeatedGroup { NONE_repeatedGroup = 0; }
enum RepeatedGroupExtensionField { NONE_RepeatedGroupExtensionField = 0; }
enum repeatedInt32 { NONE_repeatedInt32 = 0; }
enum repeatedInt64 { NONE_repeatedInt64 = 0; }
enum repeatedMessage { NONE_repeatedMessage = 0; }
enum RepeatedMessageExtensionField { NONE_RepeatedMessageExtensionField = 0; }
enum repeatedSFixed32 { NONE_repeatedSFixed32 = 0; }
enum repeatedSFixed64 { NONE_repeatedSFixed64 = 0; }
enum repeatedSInt32 { NONE_repeatedSInt32 = 0; }
enum repeatedSInt64 { NONE_repeatedSInt64 = 0; }
enum repeatedString { NONE_repeatedString = 0; }
enum repeatedUInt32 { NONE_repeatedUInt32 = 0; }
enum repeatedUInt64 { NONE_repeatedUInt64 = 0; }
enum repeating { NONE_repeating = 0; }
enum requestStreaming { NONE_requestStreaming = 0; }
enum requestTypeURL { NONE_requestTypeURL = 0; }
Expand Down Expand Up @@ -779,6 +818,24 @@ message GeneratedSwiftReservedEnums {
enum setExtensionValue { NONE_setExtensionValue = 0; }
enum shift { NONE_shift = 0; }
enum SimpleExtensionMap { NONE_SimpleExtensionMap = 0; }
enum singularBool { NONE_singularBool = 0; }
enum singularBytes { NONE_singularBytes = 0; }
enum singularDouble { NONE_singularDouble = 0; }
enum singularEnum { NONE_singularEnum = 0; }
enum singularFixed32 { NONE_singularFixed32 = 0; }
enum singularFixed64 { NONE_singularFixed64 = 0; }
enum singularFloat { NONE_singularFloat = 0; }
enum singularGroup { NONE_singularGroup = 0; }
enum singularInt32 { NONE_singularInt32 = 0; }
enum singularInt64 { NONE_singularInt64 = 0; }
enum singularMessage { NONE_singularMessage = 0; }
enum singularSFixed32 { NONE_singularSFixed32 = 0; }
enum singularSFixed64 { NONE_singularSFixed64 = 0; }
enum singularSInt32 { NONE_singularSInt32 = 0; }
enum singularSInt64 { NONE_singularSInt64 = 0; }
enum singularString { NONE_singularString = 0; }
enum singularUInt32 { NONE_singularUInt32 = 0; }
enum singularUInt64 { NONE_singularUInt64 = 0; }
enum size { NONE_size = 0; }
enum sizer { NONE_sizer = 0; }
enum source { NONE_source = 0; }
Expand Down Expand Up @@ -833,6 +890,7 @@ message GeneratedSwiftReservedEnums {
enum timeIntervalSince1970 { NONE_timeIntervalSince1970 = 0; }
enum timeIntervalSinceReferenceDate { NONE_timeIntervalSinceReferenceDate = 0; }
enum Timestamp { NONE_Timestamp = 0; }
enum toConcrete { NONE_toConcrete = 0; }
enum total { NONE_total = 0; }
enum totalArrayDepth { NONE_totalArrayDepth = 0; }
enum totalSize { NONE_totalSize = 0; }
Expand Down
Loading
Loading