Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow implementationOnly with package visibility. (1.x branch) #1532

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/protoc-gen-swift/FileGenerator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ class FileGenerator {
p.print("import Foundation\n")

if self.generatorOptions.implementationOnlyImports,
self.generatorOptions.visibility == .public {
self.generatorOptions.visibility != .internal {
errorString = """
Cannot use @_implementationOnly imports when the proto visibility is public.
Cannot use @_implementationOnly imports when the proto visibility is public or package.
Either change the visibility to internal, or disable @_implementationOnly imports.
"""
return
Expand Down