CodeGenerator support for response edition information.
#1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thomasvl
commented
Feb 26, 2024
thomasvl
commented
- Add api to get supported editions range.
- If the generator signals editions support, add the range into the generation response.
- Make the protos Editions enum Comparable since the docs document it and it then will allow other code paths to do version comparisons.
allevato
approved these changes
Feb 26, 2024
- Add api to get supported editions range. - If the generator signals editions support, add the range into the generation response. - Make the protos Editions enum Comparable since the docs document it and it then will allow other code paths to do version comparisons.
thomasvl
force-pushed
the
response_editions_plumbing
branch
from
8556867 to
483a7aa
Compare
|
Oops, pulled back some of the extension apis and just marked them deprecated, so help eventual adoption. |
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Feb 27, 2024
This backs out the plugin public interface that was just added in apple#1558. My local prototype was working using this, but I wasn't looking at supporting plugin specific features yet, and in doing that, I realized the same edition min/max information will also come in via `FeatureSetDefaults` and will have to be in sync. So dropping the interface until I plan that support out better.
thomasvl
added a commit
that referenced
this pull request
Feb 27, 2024
This backs out the plugin public interface that was just added in #1558. My local prototype was working using this, but I wasn't looking at supporting plugin specific features yet, and in doing that, I realized the same edition min/max information will also come in via `FeatureSetDefaults` and will have to be in sync. So dropping the interface until I plan that support out better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.