Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFormat decoding options to skip unknown fields/extensions. #1643

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

thomasvl
Copy link
Collaborator

Modeled after the upstream C++, provide two new decoding options to skip unknown fields while decoding TextFormat.

@thomasvl thomasvl requested review from allevato and tbkka April 29, 2024 17:52
Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the options seems like a good idea. There's some refactoring in here that I don't quite understand, though.

Sources/SwiftProtobuf/TextFormatDecoder.swift Show resolved Hide resolved
Sources/SwiftProtobuf/TextFormatDecoder.swift Show resolved Hide resolved
Sources/SwiftProtobuf/TextFormatDecoder.swift Show resolved Hide resolved
Sources/SwiftProtobuf/DoubleParser.swift Outdated Show resolved Hide resolved
Sources/SwiftProtobuf/TextFormatScanner.swift Show resolved Hide resolved
Sources/SwiftProtobuf/TextFormatScanner.swift Outdated Show resolved Hide resolved
Sources/SwiftProtobuf/TextFormatScanner.swift Show resolved Hide resolved
Modeled after the upstream C++, provide two new decoding options to skip
unknown fields while decoding TextFormat.
@thomasvl thomasvl merged commit 35c64a2 into apple:main Apr 30, 2024
10 of 11 checks passed
@thomasvl thomasvl deleted the textformat_ignore_unknown branch April 30, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants