Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to test compiling generated code in Swift 6 mode. #1737

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add a step to test compiling generated code in Swift 6 mode. #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a6f70
Add a step to test compiling generated code in Swift 6 mode.
thomasvl Dec 13, 2024
2c43af4
Make the message a linked list so it uses _Storage also.
thomasvl Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,16 @@ jobs:
- name: Compilation Tests
working-directory: swift-protobuf
run: make compile-tests PROTOC=../protobuf/cmake_build/protoc
- name: Test SPM plugin in Swift 6 mode
# This is a temporary step that basically allows us to test compiling the
# generated code in Swift 6 mode to keep an eye on the work needed.
if: startsWith(matrix.swift.version, '6.')
# This will fail until things are fixed, so don't break for it.
continue-on-error: true
working-directory: swift-protobuf
run: |
swift package tools-version --package-path PluginExamples --set 6.0
make test-spm-plugin PROTOC=../protobuf/cmake_build/protoc

api-breakage:
name: Api Breakage Compared to main branch
Expand Down
1 change: 1 addition & 0 deletions PluginExamples/Sources/Nested/Nested/Nested.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ syntax = "proto3";

message Nested {
string name = 1;
Nested next = 2;
}
Loading