Refine corpus #16
Merged
Refine corpus #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzensp
approved these changes
Sep 26, 2024
|
|
||
| x = 10 // end-of-line comment | ||
|
|
||
| y = 20 /* | ||
| multi | ||
| line | ||
| /* nested */ |
There was a problem hiding this comment.
Thanks! Filed some more issues that I found yesterday too.
Comment on lines
+16
to
+19
| res8{foo = 1; bar = 2} | ||
| res9{nested{1}} | ||
| res10{["foo"] = 1 ["bar"] = 2} | ||
| res11 { new {} new {} new {} } | ||
| res10{["foo"] = 1; ["bar"] = 2} | ||
| res11 { new {}; new {}; new {} } |
There was a problem hiding this comment.
Keeping some negative (ERROR) cases in might be valuable too (considering allowing non-semi-colon-ed same-line object literals is explicitly undesirable)
There was a problem hiding this comment.
It's actually a bug that it's being parsed this way.
But: only pkl-core parses this correctly; both pkl-intellij and tree-sitter-pkl generate incorrect parse trees here.
| @@ -1,5 +1,5 @@ | |||
| ================================================================================ | |||
| multiline | |||
| string/multilineInterpolation | |||
There was a problem hiding this comment.
Suggested change
| string/multilineInterpolation | |
| string/multiLineInterpolation |
(or rename the file)
There was a problem hiding this comment.
Argh, I did this but of course GIt had trouble tracking this thanks to case insensitive file systems.
stackoverflow
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes snippet tests from test/corpus, because they were contributing more noise than useful information; it's not practical to review those tests because there's so much code being introduced.
This also adds some more tests that were previously only covered by snippet tests.