Fixed: bad args for AssetDatabase.FindAssets #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When AppleFrameworkUtility.GetPluginLibraryPathForBuildTarget() is being called, the libraryName arguments are coming in with extensions. This causes the .bundle/.framework files to not be found during the post-build process.
botaohu
added a commit
to realitydeslab/holokit-app
that referenced
this pull request
Nov 10, 2023
|
Fixed in ToT. Apologies for the delay, we've been working on optimizing our approval process for changes. |
jared-marsau
pushed a commit
that referenced
this pull request
Mar 5, 2024
* Add GKAccessPoint triggerAccessPointWithState * Move access point stuff to its own panel and add state dropdown for trigger button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
AppleFrameworkUtility.GetPluginLibraryPathForBuildTarget()is being called, the libraryName arguments are coming in with extensions. This causes the .bundle/.framework files to not be found during the post-build process, in Unity versions 2021.3.23 and onward.Note that the documentation for
AssetDatabase.FindAssets()explicitly states that one can "[filter] assets by their filename (without extension)."In Unity versions prior to 2021.3.23, the
FindAssets()call was still returning results, despite filtering with filename extensions (counter to the documentation); however, in 2021.3.23 and onwards, this is no longer the case, and so in the variousOnProcessFrameworkscalls, we must not include the file extensions.