Fix OnApplicationStart DllNotFoundException in Unity Editor for Windows #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jared-marsau
added a commit
that referenced
this pull request
Jan 7, 2025
* Microsoft's Unity linter asked me to fix this. * Reorganizing some calls and order of operations for two reasons: - Compatibility with Unity's batchmode - Avoid interactions with the Asset Database while it's in an undefined state - defer to `OnPostprocessAllAssets` * Unity project version bump. * I feel like this is pretty close to what it needs to be. I'll test it out tomorrow - but currently it works in just the local Apple.Core Unity project. I'll go through various builds in both Editor and Batch mode builds to check. * Addressing review feedback and cleaning up some comment formatting here and there. * No gelpers allowed. * Version bump. * Tested with the following and works: - Built all plug-ins - Created new project and imported Apple.Core and the GameKit plug-ins - Built in the Editor for iPad, generated Xcode project works as expected - Built on command line with batch mode, generated Xcode project works as expected. --------- Co-authored-by: Adam Szofran <aszofran@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When starting the Unity Editor on Windows while using AppleUnityPlugins, we get the following error:
Expected behaviour
We should not get any Error in the Editor.
Fix
Add ifdef around the Dll imported methods.