Fix OnApplicationStart DllNotFoundException in Unity Editor for Windows

[Pomdap]

Issue

When starting the Unity Editor on Windows while using AppleUnityPlugins, we get the following error:

DllNotFoundException: AppleCoreNativeMac assembly:<unknown assembly> type:<unknown type> member:(null)
Apple.Core.Availability.OnApplicationStart () (at ./Packages/com.apple.unityplugin.core/Runtime/Availability.cs:13)

Expected behaviour

We should not get any Error in the Editor.

Fix

Add ifdef around the Dll imported methods.

[AdamSzApple]

Hopefully this issue is fixed by Apple.Core 3.1.7, merged on January 7. Thanks for bringing it to our attention. Please reopen this PR if issues remain.

[Niezoor]

This issue still persists in Apple.Core 3.1.7 and Apple.GameKit 3.0.1

[AdamSzApple]

Reopened. Thanks for letting us know.

[LovePiktiv]

I thought I would mention that this also occurs in the GameKit package as well. The DefaultHandlers.cs file has two classes, DefaultNSExceptionHandler and DefaultNSErrorHandler. They each have an Init() function that cause DllNotFoundExceptions on the Windows editor upon entering play mode.
Solution: Much the same as Pomdap's pull request, I think you can solve it by wrapping each of those functions with ifdefs to exclude it from non-MacOS editors like this:

#if UNITY_EDITOR_OSX || (!UNITY_EDITOR && (UNITY_IOS || UNITY_TVOS || UNITY_STANDALONE_OSX || UNITY_VISIONOS))
        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
        public static void Init()
        {
            Interop.DefaultNSErrorHandler_Set(ThrowNSError);
        }
#endif

This is with Core 3.1.8 and GameKit 3.0.2.
I'm not super familiar with Git but I can try to make another pull request if that would be helpful.

[TeorikDeli]

I think the issue still exits, this is the log from Windows Unity Editor:

Apple.GameKit.DefaultNSErrorHandler.Init () (at ./Library/PackageCache/com.apple.unityplugin.gamekit@1be1d3078587/Source/DefaultHandlers.cs:35)


DllNotFoundException: GameKitWrapper assembly:<unknown assembly> type:<unknown type> member:(null)
Apple.GameKit.DefaultNSExceptionHandler.Init () (at ./Library/PackageCache/com.apple.unityplugin.gamekit@1be1d3078587/Source/DefaultHandlers.cs:14)

DllNotFoundException: AppleCoreNativeMac assembly:<unknown assembly> type:<unknown type> member:(null)
Apple.Core.Availability.get_RuntimeEnvironment () (at ./Library/PackageCache/com.apple.unityplugin.core@006751853658/Runtime/Availability.cs:15)
Apple.Core.Availability.OnApplicationStart () (at ./Library/PackageCache/com.apple.unityplugin.core@006751853658/Runtime/Availability.cs:206)```