fix: show error if missing jobs.

appleboy · Jan 16, 2017 · 7ba6170 · 7ba6170
1 parent 4ce3a1e
commit 7ba6170
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/plugin.go b/plugin.go
@@ -36,13 +36,20 @@ func (p Plugin) Exec() error {
 		return errors.New("missing jenkins config")
 	}
 
+	jobs := trimElement(p.Job)
+
+	if len(jobs) == 0 {
+		return errors.New("missing jenkins job")
+	}
+
 	auth := &Auth{
 		Username: p.Username,
 		Token:    p.Token,
 	}
+
 	jenkins := NewJenkins(auth, p.BaseURL)
 
-	for _, value := range trimElement(p.Job) {
+	for _, value := range jobs {
 		jenkins.trigger(value, nil)
 	}
 

diff --git a/plugin_test.go b/plugin_test.go
@@ -24,6 +24,22 @@ func TestMissingJenkinsConfig(t *testing.T) {
 	assert.NotNil(t, err)
 }
 
+func TestMissingJenkinsJob(t *testing.T) {
+	plugin := Plugin{
+		BaseURL:  "http://example.com",
+		Username: "foo",
+		Token:    "bar",
+	}
+
+	err := plugin.Exec()
+	assert.NotNil(t, err)
+
+	plugin.Job = []string{"   "}
+
+	err = plugin.Exec()
+	assert.NotNil(t, err)
+}
+
 func TestPluginTriggerBuild(t *testing.T) {
 	plugin := Plugin{
 		BaseURL:  "http://example.com",