Update to golang-jwt V5 #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error types that were being used were removed in v5
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 87.36% 88.76% +1.40%
==========================================
Files 1 1
Lines 459 454 -5
==========================================
+ Hits 401 403 +2
+ Misses 45 38 -7
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gblandinkingland
commented
Feb 5, 2024
Comment on lines
+444
to
446
| if claims["exp"] == nil { | ||
| mw.unauthorized(c, http.StatusBadRequest, mw.HTTPStatusMessageFunc(ErrMissingExpField, c)) | ||
| return |
There was a problem hiding this comment.
I wasn't sure if this should be kept, or if the WithExpirationRequired should just always be added similar to how I added WithTimeFunc.
Added test case for using the expiration required parser option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the golang-jwt/jwt dependency to V5
Updates an error check in the middleware due to expanded validation in V5
Modifies a check in the refresh flow due to the reworking of errors in V5
Let me know if additional changes need to be made, or if I missed anything in the contribution process.
Thanks!