Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sp info endpoint - chain info always null #908

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

jcace
Copy link
Contributor

@jcace jcace commented Jan 30, 2023

closes #905

  • Fixed incorrect error handling:
if err != nil { // we should do this if err *IS* nil!
	out[i].ChainInfo = ci
}
  • Also took the opportunity to speed up the querying of ChainInfo, as the request was taking 30+ seconds to run in prod. In local testing, got it down from 10 seconds to under 2 seconds.

@jcace jcace marked this pull request as ready for review January 31, 2023 00:01
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcace
Copy link
Contributor Author

jcace commented Jan 31, 2023

API Request/response screenshot

Screenshot 2023-01-30 at 6 40 28 PM

@jcace jcace merged commit 653dcf0 into dev Jan 31, 2023
@jcace jcace mentioned this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/public/miners - chain_info is null
2 participants