Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate queue disk usage #945

Merged
merged 3 commits into from
Mar 13, 2023
Merged

fix duplicate queue disk usage #945

merged 3 commits into from
Mar 13, 2023

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Mar 12, 2023

-- fix by essentially removing it - on shuttle load we go through the level db with the saved pins and reconstruct the duplicate queue into a map from uint64 to bool and use that while the program is running

… shuttle load we go through the level db with the saved pins and reconstruct the duplicate queue into a map from uint64 to bool and use that while the program is running
@snissn snissn requested review from Zorlin, alvin-reyes and en0ma March 12, 2023 23:23
10d9e
10d9e previously approved these changes Mar 12, 2023
Copy link
Contributor

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Zorlin Zorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be deploying this on shuttle-9 as-is, but please fix my two changes before we deploy it to all shuttles. Thanks for the awesome turnaround time!

pinner/pinmgr.go Outdated Show resolved Hide resolved
pinner/pinmgr.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Zorlin Zorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicatee? Close ;)

Copy link
Contributor

@Zorlin Zorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!!

@Zorlin
Copy link
Contributor

Zorlin commented Mar 13, 2023

LGTM. Merged.

@Zorlin Zorlin merged commit 874bb6e into dev Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants