-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicate queue disk usage #945
Conversation
… shuttle load we go through the level db with the saved pins and reconstruct the duplicate queue into a map from uint64 to bool and use that while the program is running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be deploying this on shuttle-9 as-is, but please fix my two changes before we deploy it to all shuttles. Thanks for the awesome turnaround time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicatee? Close ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!!!
LGTM. Merged. |
-- fix by essentially removing it - on shuttle load we go through the level db with the saved pins and reconstruct the duplicate queue into a map from uint64 to bool and use that while the program is running