Skip to content

Commit

Permalink
Fix ABORT directive protocol mismatch
Browse files Browse the repository at this point in the history
I waffled on whether the ABORT directive should print an output line
count of 0, to keep it consistent with other no-args directives (e.g.
INIT_THREADS) that do so. But as of the previous commit, the
configurator was emitting a 0 while the launcher was expected no 0.

This commits reconciles the behavior, removing the emission of 0.
If we need arguments to ABORT in the future, we can update both the
launcher and configurator simultaneously to accommodate that.

This should fix the confusing "Ignoring 1 trailing output lines"
message whenever application launch gets aborted.
  • Loading branch information
ctrueden committed Feb 6, 2025
1 parent 85849e8 commit 78b591b
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/commonMain/kotlin/main.kt
Original file line number Diff line number Diff line change
Expand Up @@ -602,10 +602,7 @@ private fun executeDirectives(
lines.forEach { println(it) }
}
}
if (abort) {
println("ABORT")
println("0")
}
if (abort) println("ABORT")
}

// -- Helper functions --
Expand Down

0 comments on commit 78b591b

Please sign in to comment.