Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a way to set span attributes without overriding #869

Open
1 of 3 tasks
unflxw opened this issue Jul 13, 2023 · 1 comment
Open
1 of 3 tasks

Implement a way to set span attributes without overriding #869

unflxw opened this issue Jul 13, 2023 · 1 comment
Labels
chore

Comments

@unflxw
Copy link
Contributor

unflxw commented Jul 13, 2023 •
edited by tombruijn
Loading

This issue is spun off from a comment in #862. Implement a way to set the name and attributes for a span without overriding it, similar to how it was done for the sample data in #862.

To do

  • Implement and expose set_attribute_if_nil
  • Implement and expose set_name_if_nil, Add set_name_if_nil helper #944
  • Use them in our instrumentations if/when relevant (at close time)
@unflxw unflxw added the chore label Jul 13, 2023
tombruijn added a commit that referenced this issue May 24, 2024
@tombruijn
Add set_name_if_nil helper
eaa5a14 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

Add the name field to the span struct to avoid having to update the
extension and agent to handle this logic.

Part of #869
tombruijn added a commit that referenced this issue May 24, 2024
@tombruijn
Add set_name_if_nil helper
c1c0ca1 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

Add the name field to the span struct to avoid having to update the
extension and agent to handle this logic.

Part of #869
@tombruijn tombruijn mentioned this issue May 24, 2024
Closed
tombruijn added a commit that referenced this issue May 24, 2024
@tombruijn
Add set_name_if_nil helper
7b75ae1 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

Add the name field to the span struct to avoid having to update the
extension and agent to handle this logic.

Part of #869
tombruijn added a commit that referenced this issue May 24, 2024
@tombruijn
Add set_name_if_nil helper
01f6d03 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

Add the name field to the span struct to avoid having to update the
extension and agent to handle this logic.

Part of #869
tombruijn added a commit that referenced this issue May 24, 2024
@tombruijn
Add set_name_if_nil helper
0b84e60 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

Add the name field to the span struct to avoid having to update the
extension and agent to handle this logic.

Part of #869
tombruijn added a commit that referenced this issue May 24, 2024
@tombruijn
Add set_name_if_nil helper
5ee70d7 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

This change requires an update to the extension.
See PR appsignal/appsignal-agent#1158

Part of #869
@tombruijn tombruijn mentioned this issue May 24, 2024
Merged
tombruijn added a commit that referenced this issue May 27, 2024
@tombruijn
Add set_name_if_nil helper
aa37617 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

This change requires an update to the extension.
See PR appsignal/appsignal-agent#1158

Part of #869
@tombruijn tombruijn self-assigned this May 28, 2024
tombruijn added a commit that referenced this issue Jun 3, 2024
@tombruijn
Add set_name_if_nil helper
c76fff0 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

This change requires an update to the extension.
See PR appsignal/appsignal-agent#1158

Part of #869
tombruijn added a commit that referenced this issue Jun 3, 2024
@tombruijn
Add set_name_if_nil helper
4508bd1 
Add helper to not set the name on a span if it's already set. We can use
this to only set the span name (and the root span's (action) name), to
not overwrite custom (action) names set by the app.

This change requires an update to the extension.
See PR appsignal/appsignal-agent#1158

Part of #869
@tombruijn tombruijn changed the title Implement a way to set span name and attributes without overriding Implement a way to set span attributes without overriding Jun 3, 2024
@tombruijn
Copy link
Member

I've added it for span name, but won't implement it for attributes, because I have no purpose for it myself now. Unassigning and throwing it back on the backlog.

@tombruijn tombruijn removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tombruijn @unflxw