Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Underscored environment variables are always overwritten #316

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

jeffkreeftmeijer
Copy link
Member

@jeffkreeftmeijer jeffkreeftmeijer commented Mar 12, 2018

As discussed in #315 (comment).

@jeffkreeftmeijer jeffkreeftmeijer self-assigned this Mar 12, 2018
@tombruijn tombruijn added the bug label Mar 12, 2018
@tombruijn tombruijn changed the title Underscored environment variables are always overwritten 🐞 Underscored environment variables are always overwritten Mar 12, 2018
@tombruijn tombruijn force-pushed the unset-env-variables branch from a2aea74 to dbf1119 Compare March 15, 2018 15:44
@tombruijn
Copy link
Member

Rebased to fix conflict. If green, let's merge.

@tombruijn tombruijn force-pushed the unset-env-variables branch from dbf1119 to 6a85230 Compare March 19, 2018 10:52
@tombruijn
Copy link
Member

Pushed fix that re-added the @agent_version module attribute caused by incorrectly solved merge conflict. Rebuilding..

@tombruijn tombruijn merged commit 6149b79 into develop Mar 19, 2018
@tombruijn tombruijn deleted the unset-env-variables branch March 19, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants