Don't set session when send_session_data is false #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this is the same patch as 96c6036, but for session data. Currently, the send_session_data configuration option is checked in appsignal_plug, in Appsignal.Plug.set_session_data/2-3. Since session data is now also added from appsignal_phoenix, and because there's already a distinction between sample data and parameters in Appsignal.Span, Appsignal.Span.set_sample_data/3-4 now checks the send_session_data configuration if the passed key equals "session-data". The implementation in appsignal_plug can be removed when depending on the upcoming version of this library.
jeffkreeftmeijer
force-pushed
the
send_session_data
branch
from
6c8286e to
9e6fed7
Compare
tombruijn
approved these changes
May 27, 2022
luismiramirez
approved these changes
May 30, 2022
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
May 30, 2022
Since appsignal 2.2.13 (which includes appsignal/appsignal-elixir#771 and appsignal/appsignal-elixir#772), the app's configuration is checked whenever parameters or session data is added to the current span. This patch updates the appsignal version dependency to 2.2.13 or higher, and removes the duplicate checks from Appsignal.Plug.
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
May 30, 2022
Since appsignal 2.2.13 (which includes appsignal/appsignal-elixir#771 and appsignal/appsignal-elixir#772), the app's configuration is checked whenever parameters or session data is added to the current span. This patch updates the appsignal version dependency to 2.2.13 or higher, and removes the duplicate checks from Appsignal.Plug.
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
Jun 1, 2022
* Use Span.to_map to test Plug.set_conn_data/2 The current Elixir integration version automatically handles the skip parameter and skip session data options, meaning that logic can be removed from the Plug integration. To make sure everything keeps working, this patch adds two tests that ensure the params and session data is properly set right now, and after the removal. * Remove config checks for params and session data Since appsignal 2.2.13 (which includes appsignal/appsignal-elixir#771 and appsignal/appsignal-elixir#772), the app's configuration is checked whenever parameters or session data is added to the current span. This patch updates the appsignal version dependency to 2.2.13 or higher, and removes the duplicate checks from Appsignal.Plug.
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
Jun 1, 2022
* Use Span.to_map to test Plug.set_conn_data/2 The current Elixir integration version automatically handles the skip parameter and skip session data options, meaning that logic can be removed from the Plug integration. To make sure everything keeps working, this patch adds two tests that ensure the params and session data is properly set right now, and after the removal. * Remove config checks for params and session data Since appsignal 2.2.13 (which includes appsignal/appsignal-elixir#771 and appsignal/appsignal-elixir#772), the app's configuration is checked whenever parameters or session data is added to the current span. This patch updates the appsignal version dependency to 2.2.13 or higher, and removes the duplicate checks from Appsignal.Plug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is the same patch as 96c6036, but for session data.
Currently, the send_session_data configuration option is checked in Appsignal.Plug.set_session_data/2-3.
Since sesion data is now also added from appsignal_phoenix, and because there's already a distinction between sample data and parameters in Appsignal.Span, Appsignal.Span.set_sample_data/3-4 now checks the send_session_data configuration if the passed key equals "sesion_data".
The implementation in appsignal_plug can be removed as soon as it depends on the upcoming version of this library.