Add elixir 1.15 to CI #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
jeffkreeftmeijer
force-pushed
the
add-elixir-1.15-to-ci
branch
2 times, most recently
from
fd90167 to
3bdaf25
Compare
tombruijn
requested changes
Jun 8, 2023
jeffkreeftmeijer
force-pushed
the
add-elixir-1.15-to-ci
branch
3 times, most recently
from
bb30aa2 to
ef0f631
Compare
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
Add 1.15.0 to .semaphore/versions.rb
jeffkreeftmeijer
force-pushed
the
add-elixir-1.15-to-ci
branch
3 times, most recently
from
4a9f9b5 to
1eeda8e
Compare
To resolve the compilation error in file test/mix/tasks/appsignal_diagnose_test.exs on Elixir 1.15, explicitly require Appsignal.Agent before referring to it.
Updating to Elixir 1.15 produces the following errors when running
dialyzer:
Error loading decimal, dependency list may be incomplete.
{~c"no such file or directory", ~c"decimal.app"}
Error loading decimal, dependency list may be incomplete.
{~c"no such file or directory", ~c"decimal.app"}
Logger.warn/1 is deprecated in favor of Logger.warning/1. This patch replaces all occurrences of the former with the latter.
Since Logger.warn is now deprecated, add logging functions to AppSignal.Utils that call Logger.warn on Elixir versions before 1.11, and Logger.warning for newer versions. This patch can be removed when dropping support for Elixir 1.10.
jeffkreeftmeijer
force-pushed
the
add-elixir-1.15-to-ci
branch
from
9727d5d to
5686702
Compare
The new dialyzer warnings show an issue in the return types of the Nif's diagnose function that can never be reached. Ignore these errors for now in order to fix the build and ship the changes needed to run CI on Elixir 1.15.
|
This should be good to go, with some more changes and some ignored dialyzer warnings. I've opened #853 to make sure we get to those later. |
tombruijn
approved these changes
Jun 9, 2023
unflxw
approved these changes
Jun 9, 2023
This is a message from the daily scheduled checks. |
luismiramirez
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Elixir 1.15.0-rc.1 to CI, and fix a compilation issue introduced in Elixir 1.15 by using rebar instead of mix to install the ssl_verify_fun dependency for now.
[skip changeset]