Remove unmaintained Elixir/Erlang versions #864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove Erlang versions that are incompatible with currently maintained Elixir versions.
These are mostly about SSL handling and passing references to the NIF.
Mostly for 1.10, although some were for long unmaintained versions such as 1.5.
Remove the `Appsignal.Stacktrace.get/0` macro, since it is just an alias for `__STACKTRACE__` after removing special cases for older Elixir versions. Rearrange the tests for the `Appsignal.Stacktrace` module to talk about `format/1`, the actual function under test, instead of `get/0`.
Remove the wrappers around `Application.compile_env` that existed as a special case for old Elixir versions at `Appsignal.Utils` and `Mix.Appsignal.Utils`.
Set the Elixir version requirement to `~> 1.11` in `mix.exs`, which should show a warning for users of earlier Elixir versions.
|
✔️ All good! |
unflxw
requested review from
jeffkreeftmeijer,
luismiramirez and
tombruijn
and removed request for
jeffkreeftmeijer
unflxw
added a commit
to appsignal/appsignal-elixir-plug
that referenced
this pull request
Jun 26, 2023
Remove Elixir 1.9, Elixir 1.10 and Erlang/OTP 20 from the CI matrix. See appsignal/appsignal-elixir#864.
2 tasks
unflxw
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 26, 2023
Remove Elixir 1.9, Elixir 1.10 and Erlang/OTP 20 from the CI matrix. See appsignal/appsignal-elixir#864.
unflxw
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 26, 2023
Remove Elixir 1.9, Elixir 1.10 and Erlang/OTP 20 from the CI matrix. See appsignal/appsignal-elixir#864.
unflxw
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 26, 2023
Remove Elixir 1.9, Elixir 1.10 and Erlang/OTP 20 from the CI matrix. See appsignal/appsignal-elixir#864.
3 tasks
tombruijn
approved these changes
Jun 27, 2023
This comment has been minimized.
This comment has been minimized.
8 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
luismiramirez
approved these changes
Jul 11, 2023
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This is a message from the daily scheduled checks. |
|
Closing this for now. We hope to pick this up for a major release in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for Elixir 1.9, Elixir 1.10 and Erlang/OTP 20.
To do
Commits
Remove unmaintained Elixir versions from CI
Also remove Erlang versions that are incompatible with currently
maintained Elixir versions.
Remove special cases for Erlang/OTP 20
These are mostly about SSL handling and passing references to the
NIF.
Remove special cases for old Elixir versions
Mostly for 1.10, although some were for long unmaintained versions
such as 1.5.
Rearrange stacktrace tests
Remove the
Appsignal.Stacktrace.get/0macro, since it is just analias for
__STACKTRACE__after removing special cases for olderElixir versions.
Rearrange the tests for the
Appsignal.Stacktracemodule to talkabout
format/1, the actual function under test, instead ofget/0.Remove compile_env wrappers
Remove the wrappers around
Application.compile_envthat existedas a special case for old Elixir versions at
Appsignal.UtilsandMix.Appsignal.Utils.Bump minimum Elixir version to 1.11
Set the Elixir version requirement to
~> 1.11inmix.exs, whichshould show a warning for users of earlier Elixir versions.