Remove extra quotes around node names #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the returned nodeName was converted to a string with to_string(), which turns the JSON representation into a string. This includes quotes to indicate the value is indeed a string. This patch uses as_str(), which returns an option. The node name is only set if a str is actually returned.
Like with node names in node metrics, also remove the quotes from the names in pod and volume metrics.
matsimitsu
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the node names were wrapped in double quotes, as an artefact of their JSON roots. This patch makes sure the quotes are removed by converting the values to str before producing the string outputs.
Closes #20
[skip changeset]