Add Helm chart #33
Open
Add Helm chart #33
+237
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkdir charts && cd charts && helm create appsignal-kubernetes
The chart version matches the Cargo version, so there's no reason to duplicate it in the chart.
luismiramirez
approved these changes
Mar 14, 2025
tombruijn
reviewed
Mar 17, 2025
Comment on lines
+21
to
+22
| git config user.name "$GITHUB_ACTOR" | ||
| git config user.email "$GITHUB_ACTOR@users.noreply.github.com" |
There was a problem hiding this comment.
Is this used to make commit?
I can imagine this creates a unverified commit or verification problem for the created commits if we try to make them in the name of a person who initiated the release.
I would recommend doing the same thing we do in the collector and agent:
- Author commits in the name of @AppSignalReleaseBot
- Sign the commits using its signing key
- Then, if possible, add the GitHub actor in the commit message and/or tag.
Here's how it's done in the collector: https://github.com/appsignal/appsignal-collector/blob/1f6959017907f87acb3b4bf64e77a4239f850219/.github/workflows/publish_release.yml#L39-L51
You'll need to have the secrets for this set up, which I can do.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a Helm chart, which is currently a copy of the deployment.yaml.
As per https://helm.sh/docs/chart_template_guide/getting_started/.
[skip changeset]