Skip to content

Commit

Permalink
Merge pull request #971 from appsignal/otel-diag-logger
Browse files Browse the repository at this point in the history
Add OpenTelemetry diag logger
  • Loading branch information
luismiramirez authored Jan 11, 2024
2 parents c49dbf3 + 6d4cd2b commit fefe599
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 2 deletions.
6 changes: 6 additions & 0 deletions .changesets/add-opentelemetry-diag-logger.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
bump: "patch"
type: "add"
---

When the AppSignal log level is set to "trace". Additional information from the OpenTelemetry instrumentations is now logged.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { demo } from "./demo"
import { VERSION } from "./version"
import { setParams, setSessionData } from "./helpers"
import { BaseLogger, Logger, LoggerFormat, LoggerLevel } from "./logger"
import { diag, DiagConsoleLogger, DiagLogLevel } from "@opentelemetry/api"

import { Instrumentation } from "@opentelemetry/instrumentation"
import {
Expand Down Expand Up @@ -157,6 +158,7 @@ export class Client {
this.#metrics = new Metrics()
if (this.config.data.initializeOpentelemetrySdk) {
this.#sdk = this.initOpenTelemetry()
this.setUpOpenTelemetryLogger()
}
}
} else {
Expand Down Expand Up @@ -416,6 +418,17 @@ export class Client {
return logger
}

/**
* Sets up the OpenTelemetry diag logger based on our integration logger level.
* If our integration logger level is "silly" ("trace"), the OpenTelemetry diag debug messages
* are logged.
*/
private setUpOpenTelemetryLogger(): void {
if (this.config.data["logLevel"] === "trace") {
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG)
}
}

/**
* Stores the client in global object after initializing
*/
Expand Down

0 comments on commit fefe599

Please sign in to comment.