Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option apiKey should be pushApiKey #470

Closed
5 tasks done
tombruijn opened this issue Oct 29, 2021 · 4 comments
Closed
5 tasks done

Config option apiKey should be pushApiKey #470

tombruijn opened this issue Oct 29, 2021 · 4 comments
Assignees
Labels

Comments

@tombruijn
Copy link
Member

tombruijn commented Oct 29, 2021

The Node.js integration uses apiKey for the push_api_key config option used by the Elixir and Ruby integrations. They should be the same.

TODO

@tombruijn tombruijn added the bug label Oct 29, 2021
@tombruijn
Copy link
Member Author

@jeffkreeftmeijer @thijsc Do you remember why it's called apiKey now and can we rename it to pushApiKey?

@jeffkreeftmeijer
Copy link
Member

No, and yes. I think we can update this, as long as the change is backward compatible.

@tombruijn
Copy link
Member Author

We're moving forward with this. I'm removing the discuss label.

@tombruijn tombruijn removed the discuss label Nov 17, 2021
@tombruijn tombruijn self-assigned this Nov 22, 2021
@tombruijn
Copy link
Member Author

Fixed in #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants