Rename apiKey config option to pushApiKey #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
push-api-key
branch
3 times, most recently
from
ca46a87 to
88d82b4
Compare
Rename the `apiKey` config option to `pushApiKey` to match the naming in the other integrations (Ruby & Elixir). If the `apiKey` config option is set (which will be the case for everyone upgrading) the `pushApiKey` config option will be set with the `apiKey` value. It does only for the `apiKey` option given to the constructor, the env var is mapped to the new key by the config keys map.
tombruijn
force-pushed
the
push-api-key
branch
from
88d82b4 to
1b43921
Compare
5 tasks
luismiramirez
approved these changes
Nov 22, 2021
unflxw
approved these changes
Nov 23, 2021
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Dec 6, 2021
In PR appsignal/appsignal-nodejs#507 on the Node.js integration we renamed `apiKey` to `pushApiKey` to make it more consistent with the other integrations. Update the code in the installer to match. [skip changeset] as users won't notice this change, it only makes it more readable for us.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Dec 6, 2021
In PR appsignal/appsignal-nodejs#507 on the Node.js integration we renamed `apiKey` to `pushApiKey` to make it more consistent with the other integrations. Update the code in the installer to match. [skip changeset] as users won't notice this change, it only makes it more readable for us.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Dec 6, 2021
In PR appsignal/appsignal-nodejs#507 on the Node.js integration we renamed `apiKey` to `pushApiKey` to make it more consistent with the other integrations. Update the code in the installer to match. [skip changeset] as users won't notice this change, it only makes it more readable for us.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Dec 7, 2021
In PR appsignal/appsignal-nodejs#507 on the Node.js integration we renamed `apiKey` to `pushApiKey` to make it more consistent with the other integrations. Update the code in the installer to match. I've only not updated the `validatePushApiKey` function, because that meant updating the core package too. I think it would make more sense to remove that function from the core package and use the Node.js package's validator instead. Now we only use the core package for this one function and that function is not used by the core package. [skip changeset] as users won't notice this change, it only makes it more readable for us. [skip review] as it's only a variable name change.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Dec 7, 2021
In PR appsignal/appsignal-nodejs#507 on the Node.js integration we renamed `apiKey` to `pushApiKey` to make it more consistent with the other integrations. Update the code in the installer to match. I've only not updated the `validatePushApiKey` function, because that meant updating the core package too. I think it would make more sense to remove that function from the core package and use the Node.js package's validator instead. Now we only use the core package for this one function and that function is not used by the core package. [skip changeset] as users won't notice this change, it only makes it more readable for us. [skip review] as it's only a variable name change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
apiKeyconfig option topushApiKeyto match the naming inthe other integrations (Ruby & Elixir).
If the
apiKeyconfig option is set (which will be the case foreveryone upgrading) the
pushApiKeyconfig option will be set with theapiKeyvalue.It does only for the
apiKeyoption given to the constructor, the envvar is mapped to the new key by the config keys map.