Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated config options for next major release #738

Closed
3 tasks done
tombruijn opened this issue Sep 28, 2022 · 0 comments · Fixed by #748
Closed
3 tasks done

Remove deprecated config options for next major release #738

tombruijn opened this issue Sep 28, 2022 · 0 comments · Fixed by #748
Assignees
@tombruijn
Labels
chore

Comments

@tombruijn
Copy link
Member

tombruijn commented Sep 28, 2022 •
edited
Loading

Let's remove config options which have been deprecated in version 2 of the package. They will no longer be present in version 3 of the package (the switch to OpenTelemetry).

To do

  • Remove debug config option.
  • Remove apiKey config option. Replaced with pushApiKey.
  • Remove workingDirPath config option. Replaced with workingDirectoryPath.
@tombruijn tombruijn self-assigned this Oct 5, 2022
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove the debug config options
adb15cd 
Remove `debug` and `transactionDebugMode` config options. They have both
been replaced with the `logLevel` config option.

Remove the `Config.debug()` function. It only worked with the deprecated
config option, and isn't used anywhere.

Part of #738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove apiKey deprecated config option
51a4eb6 
The `apiKey` was replaced with the `pushApiKey` config option some time
ago. Remove the deprecated config option for the next major release.

Part of #738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove workingDirPath config option
6644def 
This has been replaced with `workingDirectoryPath` a long time ago.

Since `workingDirPath` was undocumented for Node.js, I did not add a
changeset for it. I assume no one uses it.

Part of #738
tombruijn added a commit to appsignal/diagnose_tests that referenced this issue Oct 5, 2022
@tombruijn
Remove unused debug config options
aab51e1 
Remove `debug` and `transactionDebugMode` config options. They have both
been replaced with the `logLevel` config option.

Part of appsignal/appsignal-nodejs#738
This was referenced Oct 5, 2022
Merged
Merged
tombruijn added a commit to appsignal/diagnose_tests that referenced this issue Oct 5, 2022
@tombruijn
Remove unused debug config options
258d7a9 
Remove `debug` and `transactionDebugMode` config options. They have both
been replaced with the `logLevel` config option.

Part of appsignal/appsignal-nodejs#738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove the debug config options
3c12c75 
Remove `debug` and `transactionDebugMode` config options. They have both
been replaced with the `logLevel` config option.

Remove the `Config.debug()` function. It only worked with the deprecated
config option, and isn't used anywhere.

Part of #738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove apiKey deprecated config option
80b555c 
The `apiKey` was replaced with the `pushApiKey` config option some time
ago. Remove the deprecated config option for the next major release.

Part of #738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove workingDirPath config option
8c25fcb 
This has been replaced with `workingDirectoryPath` a long time ago.

Since `workingDirPath` was undocumented for Node.js, I did not add a
changeset for it. I assume no one uses it.

Part of #738
@tombruijn tombruijn linked a pull request Oct 5, 2022 that will close this issue
Remove deprecated config options #748
Merged
tombruijn added a commit to appsignal/diagnose_tests that referenced this issue Oct 5, 2022
@tombruijn
Remove unused debug config options
090b588 
Remove `debug` and `transactionDebugMode` config options. They have both
been replaced with the `logLevel` config option.

Part of appsignal/appsignal-nodejs#738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove the debug config options
2b95a68 
Remove `debug` and `transactionDebugMode` config options. They have both
been replaced with the `logLevel` config option.

Remove the `Config.debug()` function. It only worked with the deprecated
config option, and isn't used anywhere.

Part of #738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove apiKey deprecated config option
13bc306 
The `apiKey` was replaced with the `pushApiKey` config option some time
ago. Remove the deprecated config option for the next major release.

Part of #738
tombruijn added a commit that referenced this issue Oct 5, 2022
@tombruijn
Remove workingDirPath config option
ecf02a8 
This has been replaced with `workingDirectoryPath` a long time ago.

Since `workingDirPath` was undocumented for Node.js, I did not add a
changeset for it. I assume no one uses it.

Part of #738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated config options appsignal/appsignal-nodejs
1 participant
@tombruijn