Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pino support to the logger #828

Closed
4 tasks done
unflxw opened this issue Jan 9, 2023 · 13 comments
Closed
4 tasks done

Add Pino support to the logger #828

unflxw opened this issue Jan 9, 2023 · 13 comments
Assignees

Comments

@unflxw
Copy link
Contributor

unflxw commented Jan 9, 2023

Like Winston (see #821) Pino also supports transports, so we can probably tie it into the logging API in a similar way.

In the Intercom thread from #821., the customer mentioned Pino would also be interesting to have.

To do

@backlog-helper
Copy link

backlog-helper bot commented Jan 9, 2023

✔️ All good!

New issue guide | Backlog management | Rules | Feedback

@tombruijn
Copy link
Member

@unflxw can you add a section with a To do list that describes in detail the steps someone has to take to complete this issue?

@luismiramirez luismiramirez self-assigned this Feb 20, 2023
@backlog-helper
Copy link

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

@backlog-helper
Copy link

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

@luismiramirez
Copy link
Member

Moving this to backlog until we're able to log via HTTP.

Pino transports are run as worker threads. We can't pass the client safely as an argument to the worker initialization, and as we're using TS, making users write a built file path is not an ideal solution.

@luismiramirez luismiramirez removed their assignment Feb 28, 2023
@pantajoe
Copy link

Would also be interesting for my company, we just started using Appsignal and we'd love to move our logging to Appsignal.

@unflxw
Copy link
Contributor Author

unflxw commented Apr 11, 2023

Thanks @pantajoe! We may take another look at this issue soon. In the meantime, note that we do support Winston.

@shairyar
Copy link
Member

@mgm1313
Copy link

mgm1313 commented Sep 21, 2024

Is this still being considered? Since the start of this thread, Pino has grown closer to Winston in terms of adoption and is still faster than Winston, which is why we prefer it in our stack.

pino,winston

I found this transporter in user land https://github.com/duailibe/pino-appsignal-transport, but official support would still be awesome! :)

@luismiramirez
Copy link
Member

@mgm1313 hey, thank you!

Yes, we're considering this and we're moving it ahead soon.

@kamilcglr
Copy link

Hello everyone, I would also like to see pino supported. I use Adonis and the default logger is pino. Thanks in advance.

@flozdra
Copy link

flozdra commented Oct 4, 2024

Hi there, same here. We also use AdonisJS so it would be awesome to have official support

@luismiramirez
Copy link
Member

The Pino transport has been released!

It's available in v3.5.1

You can find the docs here: https://docs.appsignal.com/logging/platforms/integrations/nodejs.html#usage-with-pino

Feel free to reach out for help and/or suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants