-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pino support to the logger #828
Comments
✔️ All good! |
@unflxw can you add a section with a To do list that describes in detail the steps someone has to take to complete this issue? |
This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.
If a blog post is not required, please add the |
This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.
If a blog post is not required, please add the |
Moving this to backlog until we're able to log via HTTP. Pino transports are run as worker threads. We can't pass the client safely as an argument to the worker initialization, and as we're using TS, making users write a built file path is not an ideal solution. |
Would also be interesting for my company, we just started using Appsignal and we'd love to move our logging to Appsignal. |
Thanks @pantajoe! We may take another look at this issue soon. In the meantime, note that we do support Winston. |
Is this still being considered? Since the start of this thread, Pino has grown closer to Winston in terms of adoption and is still faster than Winston, which is why we prefer it in our stack. I found this transporter in user land https://github.com/duailibe/pino-appsignal-transport, but official support would still be awesome! :) |
@mgm1313 hey, thank you! Yes, we're considering this and we're moving it ahead soon. |
Hello everyone, I would also like to see pino supported. I use Adonis and the default logger is pino. Thanks in advance. |
Hi there, same here. We also use AdonisJS so it would be awesome to have official support |
The Pino transport has been released! It's available in v3.5.1 You can find the docs here: https://docs.appsignal.com/logging/platforms/integrations/nodejs.html#usage-with-pino Feel free to reach out for help and/or suggestions! |
Like Winston (see #821) Pino also supports transports, so we can probably tie it into the logging API in a similar way.
In the Intercom thread from #821., the customer mentioned Pino would also be interesting to have.
To do
The text was updated successfully, but these errors were encountered: