docs->add appsignal pino transport #2065
Conversation
|
is it covered by tests? does it have docs? |
docs/transports.md
Outdated
|
|
||
| const logger = pino({ | ||
| AppsignalPinoTransport({ | ||
| client: Appsignal.client, |
There was a problem hiding this comment.
I don't think this would work with pino-transport
There was a problem hiding this comment.
Could you provide more info about how it wouldn't work with pino-transport please? I'm trying to find some info about it, but I haven't found anything.
There was a problem hiding this comment.
Hi @mcollina! Now it's compatible with pino-transport. I've updated the PR.
Yes, we have a test-setup for it working with Fastify Pino logging: https://github.com/appsignal/test-setups/blob/main/nodejs/fastify/app/src/app.ts And its docs page: https://docs.appsignal.com/logging/platforms/integrations/nodejs.html#usage-with-pino |
luismiramirez
force-pushed
the
doc-pino-appsignal
branch
from
63a8fcd to
f7845ca
Compare
luismiramirez
force-pushed
the
doc-pino-appsignal
branch
from
f7845ca to
af75f90
Compare
| <a id="@appsignal/nodejs-pino"></a> | ||
| ### @appsignal/nodejs | ||
|
|
||
| [@appsignal/nodejs](https://www.npmjs.com/package/@appsignal/nodejs) [`AppsignalPinoTransport`](https://github.com/appsignal/appsignal-nodejs/blob/337eed9b72194f9500a685410fbfc9197c4db911/src/pino_transport.ts) is the official [AppSignal](https://appsignal.com/) transport for Pino. |
There was a problem hiding this comment.
@luismiramirez I see that you have had to update this PR at least once merely to update the hash in the URL. Can you provide a URL that doesn't need to be updated so often? It would be better if the module were in a repo dedicated to its maintenance.
There was a problem hiding this comment.
@jsumners would it be better if I directly link to the appsignal-nodejs repo instead?
There was a problem hiding this comment.
Not in my opinion. I would expect to see a repo dedicated to the module when clicking on the link. I'm not blocking this, and we are currently only waiting on @mcollina to re-review, but the way you have the module homed, the following are all true:
- You can't link directly to it without using a URL that could disappear (if you link to the "main" branch and then later change the structure of the repo it will 404).
- It's super difficult to find the source code for the module because it's mixed in with other things.
- It's pretty much impossible to figure out what changes apply only to the module because the commit history is obscured by all of the other things in the repo.
Hi there! 👋🏼
We've created an AppSignal pino transport and recently released it as part of our v3.5.1 integration.
This PR adds the transport to the v7+ compatible list.